chore: move to pyproject and poetry #2471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
force-pushed
the
2405-pyproject.toml
branch
2 times, most recently
from
3f17d46 to
cc3e002
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
2 times, most recently
from
6018ff5 to
e3efaaf
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
2 times, most recently
from
779294f to
df3007b
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
from
df3007b to
1af8f3c
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
from
1af8f3c to
ef8e9af
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
13 times, most recently
from
90786fe to
92d9c24
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
from
92d9c24 to
ef8f5b6
Compare
Panaetius
force-pushed
the
2405-pyproject.toml
branch
from
7fca3e7 to
3f7a350
Compare
|
For an example of the cache: |
vigsterkr
previously approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2405
Moves all configuration to pyproject.toml
Moves building/dependency management to poetry
Gets rid of setup.py
Updates Github Actions to work with poetry
Also:
Adds caching of python dependencies between runs in the github actions, to speed things up a bit (and reduce bandwidth)
Reduces exponential backoff in our
requestswrapper so the worst case is not 17 minutes but 6seconds.Formatter the github actions to have consistent indent
Added some missing init.py (poetry threw warnings when building)
Note:
version.py.tmpl is gone,
poetry-dynamic-versioningpatches version.py directly.0.0.0is just a placeholder. The way it works is that before apoetry buildorpoetry install, it patches version.py with the correct version, and after in un-patches it again. This has the downside that the version locally is always 0.0.0, only renku installed in the env and published packages have the version actually set. I didn't notice any issues with running tests or commands with this, so I think it's fine.